Add missing ComboBox features #468
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
void uiComboboxDelete(uiCombobox *c, int n) * Unix: gtk_combo_box_text_remove * Windows: CB_DELETESTRING * Darwin: NSPopUpButton.removeItemAtIndex
void uiComboboxClear(uiCombobox *c) * Unix: gtk_combo_box_text_remove_all * Windows: CB_RESETCONTENT * Darwin: NSPopUpButton.removeAllItems
void uiComboboxInsertAt(uiComboBox *c, int n, const char *text) * Unix: gtk_combo_box_insert * Windows: CB_INSERTSTRING * Darwin: NSArrayController.insert
|
Is there anything I could help with this PR to speed up making it available in the next release? Unfortunately I also have no knowledge in ObjectiveC. |
|
Is this PR looking likely to merge into the next release? |
This was referenced Jan 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I was in need of more ComboBox functionality and it's in your backlog (#309) I took a shot at it and implemented:
I've tested this on Linux (Arch) and Windows by adding buttons for each method in the test project. Unfortunately my objective-c competence is equal to zero and I've got no macOS installation to test on right now, so that code needs a proper review/test.